On 25/10/2023 09:47, Neil Armstrong wrote: > The pm8550ve can be found with a different SID on SM8650 platforms, > make it configurable. > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/pm8550ve.dtsi | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/pm8550ve.dtsi b/arch/arm64/boot/dts/qcom/pm8550ve.dtsi > index c47646a467be..fbd8a386cef2 100644 > --- a/arch/arm64/boot/dts/qcom/pm8550ve.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8550ve.dtsi > @@ -6,6 +6,11 @@ > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/spmi/spmi.h> > > +/* (Sadly) this PMIC can be configured to be at different SIDs */ > +#ifndef PMK8550VE_SID > + #define PMK8550VE_SID 5 > +#endif My statement is still the same - NAK, for defines depending on ifndef. I believe outcome of our last discussion - including meeting in Amsterdam - was only to have defines in the board without any ifndef/ifdef. Best regards, Krzysztof
