On 21.10.2023 21:34, Luca Weiss wrote: > On Samstag, 21. Oktober 2023 19:44:20 CEST Konrad Dybcio wrote: >> On 10/19/23 06:06, Manivannan Sadhasivam wrote: >>> On Wed, Oct 18, 2023 at 10:17:15PM +0200, Konrad Dybcio wrote: >>>> On 10/18/23 16:25, Nia Espera wrote: >>>>> In a similar vein to >>>>> https://lore.kernel.org/lkml/20220530080842.37024-3-manivannan.sadhasiva >>>>> m@xxxxxxxxxx/, the remote processors on sm8350 fail to initialize with >>>>> the 'correct' (i.e., specified in downstream) IRQ type. Change this to >>>>> EDGE_RISING. >>>>> >>>>> Signed-off-by: Nia Espera <nespera@xxxxxxxxxx> >>>>> --- >>>> >>>> Hm, apparently 8250 and 7180 have the same thing. >>>> >>>> Mani, could you elaborate on this? >>> >>> So the remoteproc driver expects the wdog interrupts to be edge triggered >>> as the rest of the interrupts, but DT specifies them as level triggered. >>> This won't cause any issue during the first instance of the probe as the >>> driver requested trigger will be given precedence. But if the probe >>> defers for some reason and during the next try, request_irq() will fail >>> with error similar to below: >>> >>> irq: type mismatch, failed to map hwirq-x for interrupt-controller@xxxxxx! >>> >>> This error is often confusing and I tried to fix it. But Maz didn't agree >>> with me, so I just ended up fixing the DTs for some platform I have >>> access to. >>> >>> So ideally, DTs of all platforms should be fixed to pass correct trigger >>> type. >> So, this should be edge for all platforms, correct? > > I'd believe so, iirc when I looked at the driver it always requests that > interrupt type. > > For reference, these are my patches: > > sm6350: > https://github.com/z3ntu/linux/commit/0522b7a1b981d80884a785c7e654bb5094ea1bc2 > > sc7280: > https://github.com/z3ntu/linux/commit/ead1d7b8f5648535b857cfa9250aac2480f00ed3 Can you send those, as well as fix up other outliers? Probably won't get in for this cycle, but still very much worth to get them upstream.. Konrad
