On 22/10/2023 21:56, Luka Panio wrote: > On Sun, Oct 22, 2023 at 8:46 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> If there are no other copyrights here, why did you use BSD-3 license? > I am by no means a licensing expert, but as sm8250.dts did use BSD-3 > and other device tree's (for example sm8250-xiaomi-elish-boe.dts) did > use it, I thought I should do the same. Should I drop it? Did you base your work on these files? This would explain the license, but then please include original copyrights. > >> >> chassis-type >> >> It does not look like you tested the DTS against bindings. Please run >> `make dtbs_check W=1` (see >> Documentation/devicetree/bindings/writing-schema.rst or >> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ >> for instructions). >> > Thanks, will do. > >> 0x34 or 34? > Yes 0x24, should i tend to use decimal? Please do not trim the content that much. How can I know to what you refer here? What was in original code? 0x24? Best regards, Krzysztof
