On Sun, Oct 22, 2023 at 8:46 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > If there are no other copyrights here, why did you use BSD-3 license? I am by no means a licensing expert, but as sm8250.dts did use BSD-3 and other device tree's (for example sm8250-xiaomi-elish-boe.dts) did use it, I thought I should do the same. Should I drop it? > > chassis-type > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). > Thanks, will do. > 0x34 or 34? Yes 0x24, should i tend to use decimal? Thanks, Luka P.S. Sorry if you got duplicated email
