Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jie Luo <quic_luoj@xxxxxxxxxxx>, andersson@xxxxxxxxxx, agross@xxxxxxxxxx, konrad.dybcio@xxxxxxxxxx, mturquette@xxxxxxxxxxxx, sboyd@xxxxxxxxxx, robh+dt@xxxxxxxxxx, krzysztof.kozlowski+dt@xxxxxxxxxx, conor+dt@xxxxxxxxxx, catalin.marinas@xxxxxxx, will@xxxxxxxxxx, p.zabel@xxxxxxxxxxxxxx
Subject: Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
From: "Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>
Date: Wed, 11 Oct 2023 12:33:25 +0100
Cc: linux-arm-msm@xxxxxxxxxxxxxxx, linux-clk@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, quic_srichara@xxxxxxxxxxx
In-reply-to: <49c8a8ff-bdb9-a523-9587-d2a46d401e41@quicinc.com>
References: <20230923112105.18102-1-quic_luoj@quicinc.com> <20230923112105.18102-5-quic_luoj@quicinc.com> <10bcb0cc-19db-4914-bbc4-ef79c238a70d@linaro.org> <49c8a8ff-bdb9-a523-9587-d2a46d401e41@quicinc.com>
User-agent: Mozilla Thunderbird

On 11/10/2023 12:26, Jie Luo wrote:

0004-clk-qcom-add-clock-controller-driver-for-qca8386-qca.patch hasstyle problems, please review.
Thanks Bryan for the review. The code line mentioned by CHECK is morethan 100 columns, so i separate the lines.

Yep. Remember to align the indentation as much as possible/reasonable.Use your discretion.


---
bod

Follow-Ups:
- Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
  - From: Jie Luo

References:
- [PATCH v9 0/4] add clock controller of qca8386/qca8084
  - From: Luo Jie
- [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
  - From: Luo Jie
- Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
  - From: Bryan O'Donoghue
- Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
  - From: Jie Luo

Prev by Date: Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
Next by Date: Re: [PATCH v1 5/5] arm64: dts: qcom: sa8775p: Add ep pcie0 controller node
Previous by thread: Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
Next by thread: Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]