On 9/29/23 15:19, Nitin Rawat wrote:
This patch adds UFS host controller and Phy nodes for Qualcomm sc7280 SOC and sc7280 Board. Changes from v3: - Addresses Mani comment to include interconnect entry.
These are not the only changes you've made.
Changes from v2: - Addressed Konrad comment to update binding qcom,ufs.yaml - Addresses mani/konrad comment to align ufs clock entry in devicetree. Changes from v1: - Addressed mani comment to separate soc and board change. - Addressed mani comment to sort ufs node in ascending order. Nitin Rawat (4): scsi: ufs: qcom: dt-bindings: Add SC7280 compatible string arm64: dts: qcom: sc7280: Add UFS nodes for sc7280 soc arm64: dts: qcom: sc7280: Add UFS nodes for sc7280 IDP board dt-bindings: ufs: qcom: Align clk binding property for Qualcomm UFS Nitin Rawat (4): scsi: ufs: qcom: dt-bindings: Add SC7280 compatible string arm64: dts: qcom: sc7280: Add UFS nodes for sc7280 soc arm64: dts: qcom: sc7280: Add UFS nodes for sc7280 IDP board dt-bindings: ufs: qcom: Align clk binding property for Qualcomm UFS
And this is bad. Please use the b4 tool [1], half of the issues will be solved.. Konrad [1] https://b4.docs.kernel.org/