On 29/08/2023 15:58, Praveenkumar I wrote:
> Add ipq5332 USB3 SS UNIPHY support.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/phy/qcom,uniphy.yaml | 117 +++++++++++++++++-
> 1 file changed, 114 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml
> index cbe2cc820009..17ba661b3d9b 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,uniphy.yaml
> @@ -19,21 +19,53 @@ properties:
> enum:
> - qcom,usb-ss-ipq4019-phy
> - qcom,usb-hs-ipq4019-phy
> + - qcom,ipq5332-usb-ssphy
>
> reg:
> maxItems: 1
>
> + reg-names:
> + items:
> + - const: phy_base
Why do you need it?
> +
> + clocks:
> + maxItems: 3
> +
> + clock-names:
> + maxItems: 3
> +
> + "#clock-cells":
> + const: 0
> +
...
> examples:
> @@ -55,3 +149,20 @@ examples:
> <&gcc USB2_HSPHY_S_ARES>;
> reset-names = "por_rst", "srif_rst";
> };
> +
> + - |
> + #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
> +
> + ssuniphy@4b0000 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
