On Wed, Aug 02, 2023 at 05:57:36PM +0800, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.
>
> Signed-off-by: Liao Chang <liaochang1@xxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-imx-lpi2c.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
> index c3287c887c6f..bfa788b3775b 100644
> --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
> +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
> @@ -569,10 +569,8 @@ static int lpi2c_imx_probe(struct platform_device *pdev)
> sizeof(lpi2c_imx->adapter.name));
>
> ret = devm_clk_bulk_get_all(&pdev->dev, &lpi2c_imx->clks);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "can't get I2C peripheral clock, ret=%d\n", ret);
> - return ret;
> - }
> + if (ret < 0)
> + return dev_err_probe(&pdev->dev, ret, "can't get I2C peripheral clock\n");
you cut on this because the line was going over 100 characters? :)
In theory you shouldn't change the print message when doing such
changes and you can still split it as:
return dev_err_probe(&pdev->dev, ret,
"can't get I2C peripheral clock, ret=%d\n",
ret);
and you're even within the 80 characters.
Sorry, I missed it in the previous version, mind resending it?
Andi
