Re: [PATCH 2/9] i2c: mlxbf: Use dev_err_probe in probe function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Liao Chang <liaochang1@xxxxxxxxxx>
Subject: Re: [PATCH 2/9] i2c: mlxbf: Use dev_err_probe in probe function
From: Andi Shyti <andi.shyti@xxxxxxxxxx>
Date: Sat, 5 Aug 2023 00:11:02 +0200
Cc: florian.fainelli@xxxxxxxxxxxx, bcm-kernel-feedback-list@xxxxxxxxxxxx, rjui@xxxxxxxxxxxx, sbranden@xxxxxxxxxxxx, yangyicong@xxxxxxxxxxxxx, aisheng.dong@xxxxxxx, shawnguo@xxxxxxxxxx, s.hauer@xxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx, festevam@xxxxxxxxx, linux-imx@xxxxxxx, kblaiech@xxxxxxxxxx, asmaa@xxxxxxxxxx, loic.poulain@xxxxxxxxxx, rfoss@xxxxxxxxxx, ardb@xxxxxxxxxx, gcherian@xxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx
In-reply-to: <20230802095737.3957587-3-liaochang1@huawei.com>
References: <20230802095737.3957587-1-liaochang1@huawei.com> <20230802095737.3957587-3-liaochang1@huawei.com>

Hi Liao,

On Wed, Aug 02, 2023 at 05:57:30PM +0800, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.
> 
> Signed-off-by: Liao Chang <liaochang1@xxxxxxxxxx>

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> 

Andi

References:
- [PATCH v2 0/9] Use dev_err_probe in i2c probe function
  - From: Liao Chang
- [PATCH 2/9] i2c: mlxbf: Use dev_err_probe in probe function
  - From: Liao Chang

Prev by Date: [RFC] PM / QoS: Decouple request alloc from dev_pm_qos_mtx (alternative solution)
Next by Date: Re: [PATCH 8/9] i2c: imx-lpi2c: Use dev_err_probe in probe function
Previous by thread: [PATCH 2/9] i2c: mlxbf: Use dev_err_probe in probe function
Next by thread: [PATCH 7/9] i2c: dln2: Use dev_err_probe in probe function
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]