On Tue 11 Aug 15:49 PDT 2015, Stephen Boyd wrote: > On 07/08, Rajendra Nayak wrote: > > diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c > > index eb6a4f9..2c80d03 100644 > > --- a/drivers/clk/qcom/gcc-msm8960.c > > +++ b/drivers/clk/qcom/gcc-msm8960.c > > @@ -15,6 +15,7 @@ > > #include <linux/bitops.h> > > #include <linux/err.h> > > #include <linux/platform_device.h> > > +#include <linux/of_platform.h> > > #include <linux/module.h> > > #include <linux/of.h> > > #include <linux/of_device.h> > > @@ -3520,7 +3521,8 @@ static int gcc_msm8960_probe(struct platform_device *pdev) > > if (IS_ERR(clk)) > > return PTR_ERR(clk); > > > > - return qcom_cc_probe(pdev, match->data); > > + qcom_cc_probe(pdev, match->data); > > + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev); > > We just lost the error code from qcom_cc_probe()... > > Also, I don't like having a subnode in DT. Why can't we use the > same node as the GCC node and create a virtual child device here > for tsens? We can assign the same of_node that this platform > device has so that DT keeps working correctly. > Can't we make the gcc driver support being a child of a simple-mfd by having it attempting to acquire the regmap of the parent and falling back to creating its own mmio regmap? That way we don't need to make tsense a child of the clock device and we're still backwards compatible. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
