On 18/07/2023 04:37, Fenglin Wu wrote: > > > On 7/18/2023 3:59 AM, Krzysztof Kozlowski wrote: >> On 17/07/2023 08:25, Fenglin Wu wrote: >>> Add support for vibrator module inside Qualcomm PMI632, PM7250B, PM7325B >>> and PM7550BA PMICs. >>> >>> Signed-off-by: Fenglin Wu <quic_fenglinw@xxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml >>> index c8832cd0d7da..642408e2b35f 100644 >>> --- a/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml >>> +++ b/Documentation/devicetree/bindings/input/qcom,pm8xxx-vib.yaml >>> @@ -15,6 +15,10 @@ properties: >>> - qcom,pm8058-vib >>> - qcom,pm8916-vib >>> - qcom,pm8921-vib >>> + - qcom,pmi632-vib >>> + - qcom,pm7250b-vib >>> + - qcom,pm7325b-vib >>> + - qcom,pm7550ba-vib >> >> Aren't the last two compatible? > > There are still every different PMICs even though the vibrator module in > PM7325B and PM7550BA are the same and they share the same register base > address as well. So the vibrator modules are compatible? Then I propose to make them compatible. Best regards, Krzysztof
