On 06/07/2023 12:53, Rohit Agarwal wrote: > > On 7/6/2023 4:15 PM, Krzysztof Kozlowski wrote: >> On 06/07/2023 11:20, Rohit Agarwal wrote: >>> Remove the SoC specific entries and add a generic set of defines >>> that can be used by all the SoCs. This will remove the duplicate >>> entries among SoCs. >>> The arrangement of the defines is done according to the frequency >>> used in SoC specific entries in the driver to avoid wastage of >>> memory. >>> >>> Signed-off-by: Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx> >>> Suggested-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >> Please compile kernel with this commit and tell us what is wrong... Even >> if bindings were not an ABI, but they are, this would not work. > Do you mean that individually this commit would fail compilation? > Yes, we would need all the patches together for compilation to be > successful. Yeah, it is not bisectable. Another problem is ABI impact, but I think Konrad covered it. Best regards, Krzysztof