Re: [PATCH v6 07/13] clk: qcom: gdsc: Add support for ON only state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/22/2015 12:11 AM, Rajendra Nayak wrote:
@@ -200,6 +224,12 @@ static int gdsc_init(struct gdsc *sc)
  	if (ret)
  		return ret;
+ /* Force gdsc ON if only ON state is supported */
+	if (sc->pwrsts == PWRSTS_ON)
+		ret = gdsc_toggle_logic(sc, true);
+		if (ret)
+			return ret;

This is missing braces. Please test :)

+
  	on = gdsc_is_enabled(sc);
  	if (on < 0)
  		return on;

diff --git a/drivers/clk/qcom/gdsc.h b/drivers/clk/qcom/gdsc.h
index 87c4ace..0d1c4fb 100644
--- a/drivers/clk/qcom/gdsc.h
+++ b/drivers/clk/qcom/gdsc.h
@@ -17,6 +17,7 @@
  #include <linux/clk.h>
  #include <linux/pm_domain.h>
  #include <linux/regmap.h>
+#include <linux/reset-controller.h>

Do we need this include either? Just forward declare stuff. Same comment goes for the clk include.


--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux