On 2023-06-16 14:06:47, Abhinav Kumar wrote: > On 6/14/2023 3:49 PM, Marijn Suijten wrote: > > On 2023-06-14 14:23:38, Marijn Suijten wrote: > > <snip> > >> Tested this on SM8350 which actually has DSI 2.5, and it is also > >> corrupted with this series so something else on this series might be > >> broken. > > > > Never mind, this was a bad conflict-resolve. Jessica's original > > BURST_MODE patch was RMW'ing MDP_CTRL2, but the upstreamed patch was > > only writing, and the way I conflict-resolved that caused the write of > > BURST_MODE to overwrite the RMW DATABUS_WIDEN. > > > > If both are moved to dsi_ctrl_config(), we could do a read, add both > > flags in conditionally, and write. > > > > So just to confirm, there is no issue on your 8350 setup with widebus > enabled right? After properly conflict-resolving both series so that they either both RMW, or combine the two bit-sets (the same you just discussed _not_ doing on the DPU side for DATABUS_WIDEN|COMPRESSION...) before a single write, it works fine! - Marijn
