On 2023-06-16 14:13:22, Abhinav Kumar wrote: <snip> > > As I've asked many times before, we should inline these masks (not just > > the macros) (disclaimer: haven't reviewed if Dmitry's series actually > > does so!). > > > > Yes it does inline it. I am halfway through that rework got stuck in one > of the patches. Neat, I'm still going through it but there are some conflicts with other reworks that make it harder to review and test in parallel. > >>>>> Tested this on SM8350 which actually has DSI 2.5, and it is also > >>>>> corrupted with this series so something else on this series might be > >>>>> broken. > >>>>> > >>> > >>> Missed this response. That seems strange. > > > > No worries. But don't forget to look at the comments on patch 2/3 > > either. Some of it is a continuation of pclk scaling factor for DSC > > which discussion seems to have ceased on. > > > >>> This series was tested on SM8350 HDK with a command mode panel. > >>> > >>> We will fix the DPU-DSI handshake and post a v2 but your issue needs > >>> investigation in parallel. > >>> > >>> So another bug to track that would be great. > > > > Will see if I can set that up for you! > > > > Now, it seems this is resolved so bug is not needed? Indeed, as mentioned in another message. Looking forward to v2. - Marijn
