On Tue, Apr 18, 2023 at 09:56:12PM +0800, Shuai Jiang wrote: > Smatch Warns: > drivers/i2c/busses/i2c-qup.c:1784 qup_i2c_probe() > warn: missing unwind goto? > > The goto label "fail_runtime" and "fail" will disable qup->pclk, > but here qup->pclk failed to obtain, in order to be consistent, > change the direct return to goto label "fail_dma". > > Fixes: 10c5a8425968 ("i2c: qup: New bus driver for the Qualcomm QUP I2C controller") > Fixes: 515da746983b ("i2c: qup: add ACPI support") > Signed-off-by: Shuai Jiang <d202180596@xxxxxxxxxxx> > Reviewed-by: Dongliang Mu <dzm91@xxxxxxxxxxx> Applied to for-current, thanks! Thanks Andi, for the proper Fixes tag!
Attachment:
signature.asc
Description: PGP signature