The config/periph/system NoC clocks are wholly controlled by the RPM firmware and Linux should never ever alter their configuration. Switch them over to read-only ops to avoid that. Fixes: b1e010c0730a ("clk: qcom: Add MSM8996 Global Clock Control (GCC) driver") Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> --- drivers/clk/qcom/gcc-msm8996.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/qcom/gcc-msm8996.c b/drivers/clk/qcom/gcc-msm8996.c index 5e44d1bcca9e..588e3b67657a 100644 --- a/drivers/clk/qcom/gcc-msm8996.c +++ b/drivers/clk/qcom/gcc-msm8996.c @@ -264,7 +264,7 @@ static struct clk_rcg2 system_noc_clk_src = { .name = "system_noc_clk_src", .parent_data = gcc_xo_gpll0_gpll0_early_div, .num_parents = ARRAY_SIZE(gcc_xo_gpll0_gpll0_early_div), - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_ro_ops, }, }; @@ -284,7 +284,7 @@ static struct clk_rcg2 config_noc_clk_src = { .name = "config_noc_clk_src", .parent_data = gcc_xo_gpll0, .num_parents = ARRAY_SIZE(gcc_xo_gpll0), - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_ro_ops, }, }; @@ -306,7 +306,7 @@ static struct clk_rcg2 periph_noc_clk_src = { .name = "periph_noc_clk_src", .parent_data = gcc_xo_gpll0, .num_parents = ARRAY_SIZE(gcc_xo_gpll0), - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_ro_ops, }, }; -- 2.41.0