On Tue, 23 May 2023 at 04:58, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > > > On 5/18/2023 7:38 PM, Dmitry Baryshkov wrote: > > Rework dpu_encoder initialization code, simplifying calling sequences > > and separating common init parts. > > > > Changes since v1: > > - Withdrawn two pathes for a later consideration > > - Changed dpu_encoder_phys_init() to return void (Abhinav) > > - Added small simplifications of dpu_encoder_phys_cmd_init() and > > dpu_encoder_phys_wb_init() > > > > I had previously given these comments on the cover letter of v1, so > giving it again. > > Please mention that your series was made on top of > https://patchwork.freedesktop.org/series/116530/. > > Figured it out when I tried to apply it to my branch to test. > > I had tested v1, and between v1 and v2 i only see very trivial change, > so i think its okay to retain: > > Tested-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> # sc7280 Unfortunately patchwork ignores tags sent in the cover letter thread. > > > Dmitry Baryshkov (7): > > drm/msm/dpu: merge dpu_encoder_init() and dpu_encoder_setup() > > drm/msm/dpu: separate common function to init physical encoder > > drm/msm/dpu: drop duplicated intf/wb indices from encoder structs > > drm/msm/dpu: inline dpu_encoder_get_wb() > > drm/msm/dpu: call dpu_rm_get_intf() from dpu_encoder_get_intf() > > drm/msm/dpu: drop temp variable from dpu_encoder_phys_cmd_init() > > drm/msm/dpu: simplify dpu_encoder_phys_wb_init() > > > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 178 ++++++++---------- > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 14 +- > > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 15 +- > > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 35 ++-- > > .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 19 +- > > .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 35 +--- > > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 87 ++++----- > > 7 files changed, 140 insertions(+), 243 deletions(-) > > -- With best wishes Dmitry
