On Sonntag, 7. Mai 2023 19:53:35 CEST Dmitry Baryshkov wrote: > Using PWRSTS_RET on msm8974's MDSS_GDSC causes display to stop working. > The gdsc doesn't fully come out of retention mode. Change it's pwrsts > flags to PWRSTS_OFF_ON. +CC Rajendra & Manivannan Following the mails at [0] this was the suggested fix, which I haven't made into a patch myself yet. With this (and without the revert of the linked patch) panel init is fine again on FP2. Thanks! [0] https://lore.kernel.org/linux-arm-msm/5897497.lOV4Wx5bFT@g550jk/ Tested-by: Luca Weiss <luca@xxxxxxxxx> > > Fixes: d399723950c4 ("clk: qcom: gdsc: Fix the handling of PWRSTS_RET > support") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- > drivers/clk/qcom/mmcc-msm8974.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/mmcc-msm8974.c > b/drivers/clk/qcom/mmcc-msm8974.c index aa29c79fcd55..277ef0065aae 100644 > --- a/drivers/clk/qcom/mmcc-msm8974.c > +++ b/drivers/clk/qcom/mmcc-msm8974.c > @@ -2401,7 +2401,7 @@ static struct gdsc mdss_gdsc = { > .pd = { > .name = "mdss", > }, > - .pwrsts = PWRSTS_RET_ON, > + .pwrsts = PWRSTS_OFF_ON, > }; > > static struct gdsc camss_jpeg_gdsc = {
