Re: [PATCH 2/2] clk: qcom: mmcc-msm8974: fix MDSS_GDSC power flags

[Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>]

On 08/05/2023 11:27, Konrad Dybcio wrote:
> On 7.05.2023 19:53, Dmitry Baryshkov wrote:
> > Using PWRSTS_RET on msm8974's MDSS_GDSC causes display to stop working.
> > The gdsc doesn't fully come out of retention mode. Change it's pwrsts
> > flags to PWRSTS_OFF_ON.
> >
> > Fixes: d399723950c4 ("clk: qcom: gdsc: Fix the handling of PWRSTS_RET support")
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> This is a stopgap solution, not exactly a fix, all signs on Heaven and
> Earth say that 8974 should support retention on this GDSC!
>
> *although*
>
> pre-v2.2 chips don't

Mine is apq8074 v2.2, if I'm not mistaken.

> Konrad
> >   drivers/clk/qcom/mmcc-msm8974.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c
> > index aa29c79fcd55..277ef0065aae 100644
> > --- a/drivers/clk/qcom/mmcc-msm8974.c
> > +++ b/drivers/clk/qcom/mmcc-msm8974.c
> > @@ -2401,7 +2401,7 @@ static struct gdsc mdss_gdsc = {
> >   	.pd = {
> >   		.name = "mdss",
> >   	},
> > -	.pwrsts = PWRSTS_RET_ON,
> > +	.pwrsts = PWRSTS_OFF_ON,
> >   };
> >   
> >   static struct gdsc camss_jpeg_gdsc = {

--
With best wishes
Dmitry