Hi Bjorn, first, thanks a lot for your comments. On Fri, 7 Apr 2023 at 18:54, Bjorn Andersson <andersson@xxxxxxxxxx> wrote: > > On Fri, Feb 03, 2023 at 01:21:18PM +0100, Petr Vorel wrote: > > From: Petr Vorel <petr.vorel@xxxxxxxxx> > > > > Please add a commit message... I thought the subject would be enough, as I added all regulators from downstream. But as the approach is different, I'll be more descriptive when adding just regulators which are actually needed. > > > Signed-off-by: Petr Vorel <petr.vorel@xxxxxxxxx> > > --- > > Hi all, > > > > please what is the mapping of qcom,init-current from downstream to > > mainline? Or is it not used at all? > > > > It affects the mode the regulator operates in, you can find > regulator-system-load in a few cases in other files as reference for > when we force things into "high performance mode". > > There are some cases, such as eMMC/uSD where problems has been seen when > the regulator is allowed to operate in low power mode... +1, thank you. > > > Also, how can I verify these connections in downstream DTB? > > vdd_l1-supply = <&pm8994_s1>; > > vdd_l2_26_28-supply = <&pm8994_s3>; > > I don't think you can, without form of hardware documentation. > > I _think_ the RPM will take care of dependencies for you, and care > should be taken before changing many of the regulators... > > So I'd suggest that you simply introduce the regulators that you need to > touch from Linux today, rather than trying to add them all at once and > then build from there. Sure, makes sense. Kind regards, Petr > Regards, > Bjorn
