On 13.03.2023 22:25, Melody Olvera wrote: > > > On 3/8/2023 2:23 AM, Konrad Dybcio wrote: >> >> On 7.03.2023 00:17, Melody Olvera wrote: >>> Add nodes for IPCC, MPSS, and AOSS drivers. Also update >>> the scm node to include its interconnect. >> Quite a bit of stuff in a single commit, this could be >> separated into: >> >> - scm icc >> - aoss+ipcc >> - smp2p+mpss > > Hmm ok. Will split this patch into a few patches. > >> >>> Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx> >>> --- [...] >>> + <0x0 0x4180000 0x0 0x1000>; >> No reg-names? > > No; we don't use reg-names in the driver. Lmk if we should be. > qcom_q6v5_mss.c / qcom_q6v5_wcss.c get the 'rmb' region with [...]_byname and I think it'd scale better if we did the same here, as one day there may be a weird SoC that'd have an "XYZ" region, different to "base" and "rmb", which we would need to handle.. somehow.. Konrad
