On Tue, Mar 7, 2023 at 10:48 AM Fabio Estevam <festevam@xxxxxxxxx> wrote: > > On Tue, Mar 7, 2023 at 2:46 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > > > > Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter > > should either be selected or DRM_MSM should depend on PM_DEVFREQ. > > Since most drivers select PM_DEVFREQ instead of depending on it, > > add a select here to satisfy kconfig. > > > > WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND > > Depends on [n]: PM_DEVFREQ [=n] > > Selected by [y]: > > - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=n] || QCOM_LLCC [=n]=n) && (QCOM_COMMAND_DB [=y] || QCOM_COMMAND_DB [=y]=n) > > > > Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Link: lore.kernel.org/r/202303071922.wJqDWQpe-lkp@xxxxxxxxx > > Cc: Rob Clark <robdclark@xxxxxxxxxxxx> > > Cc: Paul Gazzillo <paul@xxxxxxxxx> > > Cc: Necip Fazil Yildiran <fazilyildiran@xxxxxxxxx> > > Cc: Chia-I Wu <olvaffe@xxxxxxxxx> > > Cc: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> > > Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > Cc: linux-arm-msm@xxxxxxxxxxxxxxx > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Cc: freedreno@xxxxxxxxxxxxxxxxxxxxx > > This fixes the warning after running 'make imx_v6_v7_defconfig', thanks: > > Tested-by: Fabio Estevam <festevam@xxxxxxxxx> https://patchwork.freedesktop.org/patch/523353 is the fix we actually want.. I thought I'd already pulled that into msm-fixes but it seems like it got lost somewhere.. I'll rectify that BR, -R