On 2023-03-01 13:42:55, Abhinav Kumar wrote: <snip> > >>> Then, for some patch hygiene, starting here: > >>> > >>>> Depends on: "Implement tearcheck support on INTF block" [3] > >>>> > >>>> Changes in V3: > >>>> - Added function prototypes > >>>> - Reordered function definitions to make change more legible > >>>> - Removed prepare_commit() function from dpu_encoder_phys_cmd > >>>> > >>>> Changes in V4: > >>>> - Reworded commit message to be more specific > >>>> - Removed dpu_encoder_phys_cmd_is_ongoing_pptx() prototype > >>> > >>> ... until here: all this info belongs /below the cut/ outside of the > >>> messge that becomes part of the commit when this patch is applied to the > >>> tree. > >> > >> For DRM, I thought we are keeping the change log above the ---- ? > >> Which means its allowed in the commit message. > > > > I hope not, seems unlikely to have different rules across kernel > > subsystems. The main point is that this changelog and dependency chain > > isn't of any value when the final patch is applied, regardless of > > whether it is "allowed". > > > > I looked at a recently posted change by Rob and change log is above the --- > > https://patchwork.kernel.org/project/dri-devel/patch/20230301185432.3010939-1-robdclark@xxxxxxxxx/ > > So we will follow that. I hope that was in error, or no-one pointed it out to Rob. As said before there is no use to having this information in the applied patch, even the kernel guidelines state so: https://docs.kernel.org/process/submitting-patches.html Other comments relevant only to the moment or the maintainer, not suitable for the permanent changelog, should also go here. **A good example of such comments might be patch changelogs which describe what has changed between the v1 and v2 version of the patch.** **Please put this information after the --- line** which separates the changelog from the rest of the patch. The version information is not part of the changelog which gets committed to the git tree. It is additional information for the reviewers. If it’s placed above the commit tags, it needs manual interaction to remove it. If it is below the separator line, it gets automatically stripped off when applying the patch: <snip> > It should be first the intf TE series and then this one. You can go > ahead and post your v2, we will rebase on top of yours. Sounds good; though as said before I'm extremely short on time making it hard to actively commit to this, especially as the catalog changes are really hard to juggle between various "local" branches to test on the many (Sony) devices we are working on. As usual, a preview of v2 is still available at: https://github.com/SoMainline/linux/commits/marijn/dpu And I will do my best to get the last comments worked out. - Marijn
