On 01/03/2023 19:08, Marijn Suijten wrote:
On 2023-03-01 08:23:28, Abhinav Kumar wrote:
On 3/1/2023 2:03 AM, Marijn Suijten wrote:
On 2023-02-21 10:42:53, Jessica Zhang wrote:
Then, for some patch hygiene, starting here:
Depends on: "Implement tearcheck support on INTF block" [3]
Changes in V3:
- Added function prototypes
- Reordered function definitions to make change more legible
- Removed prepare_commit() function from dpu_encoder_phys_cmd
Changes in V4:
- Reworded commit message to be more specific
- Removed dpu_encoder_phys_cmd_is_ongoing_pptx() prototype
... until here: all this info belongs /below the cut/ outside of the
messge that becomes part of the commit when this patch is applied to the
tree.
For DRM, I thought we are keeping the change log above the ---- ?
Which means its allowed in the commit message.
I hope not, seems unlikely to have different rules across kernel
subsystems. The main point is that this changelog and dependency chain
isn't of any value when the final patch is applied, regardless of
whether it is "allowed".
Unfortunately this is one of DRM peculiarities. So, some of the patches
have changelog in commit message.
I myself prefer to have changelog in the cover letter, but I don't
enforce that.
--
With best wishes
Dmitry
