On 11.01.2023 00:47, Konrad Dybcio wrote:
>
>
> On 11.01.2023 00:13, Bryan O'Donoghue wrote:
>> On 10/01/2023 13:21, Konrad Dybcio wrote:
>>> +#define NOC_QOS_MODE_INVALID_VAL -1
>>> +#define NOC_QOS_MODE_FIXED_VAL 0x0
>>> +#define NOC_QOS_MODE_BYPASS_VAL 0x2
>>
>> The basic fix you are applying here makes sense to me.
>>
>> But why bother with an additional _VAL defintion, you have your enum.
> Thinking about it, I was probably confused by MODE_INVALID checks in
> qcom_icc_set_bimc_qos and only now realized that it's not even called
> with MODE_INVALID.. Will surely fix!
Actually, no.. qcom_icc_set_noc_qos() writes the _VAL to
NOC_QOS_MODEn_ADDR(), so it does matter.
Konrad
>
> Konrad
>>
>> +enum qos_mode {
>> + NOC_QOS_MODE_INVALID = 0,
>> + NOC_QOS_MODE_FIXED,
>> + NOC_QOS_MODE_BYPASS,
>> +};
>>
>> ---
>> bod
