On 10/01/2023 13:21, Konrad Dybcio wrote:
+#define NOC_QOS_MODE_INVALID_VAL -1 +#define NOC_QOS_MODE_FIXED_VAL 0x0 +#define NOC_QOS_MODE_BYPASS_VAL 0x2
The basic fix you are applying here makes sense to me. But why bother with an additional _VAL defintion, you have your enum. +enum qos_mode { + NOC_QOS_MODE_INVALID = 0, + NOC_QOS_MODE_FIXED, + NOC_QOS_MODE_BYPASS, +}; --- bod