Re: [PATCH v2] qcom: scm: Add qcom_scm_set_warm_boot_addr function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>> +int qcom_scm_set_warm_boot_addr(void *entry, int cpu)
>>> 
>>> I’d really like to see if we could make the set_boot_addr and set_warm_boot_addr have the same interfaces.
>> 
>> I am working on making the interfaces similar. There is some check in
>> the platsmp.c that uses the cold boot flag array to determine the
>> present cpus. Do you think, we can ignore that check over there? If that
>> can be done, I will change the interface for cold boot too.
> 
> I don’t see any reason we can’t add qcom_scm_set_cold_boot_addr() move the flags such that they only exist in qcom_scm_set_boot_addr and make qcom_scm_set_boot_addr static.
> 
> - k

Looking at this for another minute, I think we should have the interfaces be something like:

qcom_scm_set_cold_boot_addr(void * entry, cpumask_t mask);
qcom_scm_set_warm_boot_addr(void * entry, cpumask_t mask);

- k

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux