Hi, On Fri, Dec 16, 2022 at 9:38 AM Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx> wrote: > > Rx operation on SPI GSI DMA is currently not working. > As per GSI spec, link_rx bit is to be set on GO TRE on tx > channel whenever there is going to be a DMA TRE on rx > channel. This is currently set for duplex operation only. > > Set the bit for rx operation as well. > This is part of changes required to bring up Rx. > > Fixes: 94b8f0e58fa1 ("dmaengine: qcom: gpi: set chain and link flag for duplex") > Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx> > --- > v1 -> v2: > - updated change description > --- > drivers/dma/qcom/gpi.c | 1 + > 1 file changed, 1 insertion(+) Without knowing anything about how the hardware actually works, I can say that the change looks OK to me. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>