On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
[..]
>> +
>> +static int pm8941_wled_remove(struct platform_device *pdev)
>> +{
>> + struct pm8941_wled *wled;
>> +
>> + wled = platform_get_drvdata(pdev);
>> + led_classdev_unregister(&wled->cdev);
>
> Would be nice to have a devm for this one too.
>
I agree, will hack one up.
>> +
>> + return 0;
>> +}
>> +
>> +static const struct of_device_id pm8941_wled_match_table[] = {
>> + { .compatible = "qcom,pm8941-wled" },
>> + {}
>> +};
>> +MODULE_DEVICE_TABLE(of, pm8941_wled_match_table);
>> +
>> +static struct platform_driver pm8941_wled_driver = {
>> + .probe = pm8941_wled_probe,
>> + .remove = pm8941_wled_remove,
>> + .driver = {
>> + .name = "pm8941-wled",
>> + .owner = THIS_MODULE,
>
> THIS_MODULE should be removed.
>
Right, we've had this patch in purgatory for too long time... Will update.
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
