On 02/12/2022 01:49, Doug Anderson wrote:
> Hi,
>
> On Fri, Nov 18, 2022 at 8:42 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> The qup_spi0_default pin override is exactly the same as one already in
>> sdm845.dtsi.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> ---
>>
>> Cc: Doug Anderson <dianders@xxxxxxxxxxxx>
>>
>> Changes since v1:
>> 1. New patch.
>> ---
>> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> index 02dcf75c0745..56a7afb697ed 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
>> @@ -1274,11 +1274,3 @@ ov7251_ep: endpoint {
>> };
>> };
>> };
>> -
>> -/* PINCTRL - additions to nodes defined in sdm845.dtsi */
>> -&qup_spi0_default {
>> - config {
>> - drive-strength = <6>;
>> - bias-disable;
>> - };
>> -};
>
> I guess it's more of a question for what Bjorn thinks, but I view the
> fact that the drive-strength / bias are in the dtsi file to begin with
> as more as a bug in commit 8f6e20adaaf3 ("arm64: dts: qcom: sdm845:
> enable dma for spi"), which is where these properties were introduced
> to sdm845.dtsi.
>
> The historical guidance from Bjorn was that things like
> "drive-strength" and "bias" didn't belong in the SoC dtsi file. Later
> we came to an agreement that it could be OK to put drive-strength in
> the SoC dtsi file but that bias was still problematic because it meant
> ugly "/delete-property/" stuff in the board dtsi files [1].
So let's move it from DTSI to all boards? Although what if the board
does not use SPI0?
Best regards,
Krzysztof
