Hi Lina, Gilad On 02/03/2015 11:21 PM, Lina Iyer wrote: > On Tue, Feb 03 2015 at 02:59 -0700, Stanimir Varbanov wrote: >> Hi Gilad, >> >> Thanks for the patch. >> >> On 01/31/2015 02:46 AM, Gilad Avidov wrote: >>> Qualcomm PMIC Arbiter version-2 changes from version-1 are: >>> >>> - Some different register offsets. >>> - New channel register space, one per PMIC peripheral (ppid). >>> All tx traffic uses these channels. >>> - New observer register space. All rx trafic uses this space. >>> - Different command format for spmi command registers. >>> >>> Signed-off-by: Gilad Avidov <gavidov@xxxxxxxxxxxxxx> >>> Acked-by: Sagar Dharia <sdharia@xxxxxxxxxxxxxx> >>> --- >>> .../bindings/spmi/qcom,spmi-pmic-arb.txt | 6 +- >>> drivers/spmi/spmi-pmic-arb.c | 310 >>> +++++++++++++++++---- >>> 2 files changed, 260 insertions(+), 56 deletions(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt >>> b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt >>> index 715d099..e16b9b5 100644 >>> --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt >>> +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt >>> @@ -1,6 +1,6 @@ >>> Qualcomm SPMI Controller (PMIC Arbiter) >>> >>> -The SPMI PMIC Arbiter is found on the Snapdragon 800 Series. It is >>> an SPMI >>> +The SPMI PMIC Arbiter is found on Snapdragon chipsets. It is an SPMI >>> controller with wrapping arbitration logic to allow for multiple >>> on-chip >>> devices to control a single SPMI master. >>> >>> @@ -19,6 +19,10 @@ Required properties: >>> "core" - core registers >>> "intr" - interrupt controller registers >>> "cnfg" - configuration registers >>> + Registers used only for V2 PMIC Arbiter: >>> + "chnls" - tx-channel per virtual slave registers. >>> + "obsrvr" - rx-channel (called observer) per virtual slave >>> registers. >>> + >>> - reg : address + size pairs describing the PMIC arb register sets; >>> order must >>> correspond with the order of entries in reg-names >>> - #address-cells : must be set to 2 >>> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c >>> index 20559ab..818b2cf 100644 >>> --- a/drivers/spmi/spmi-pmic-arb.c >>> +++ b/drivers/spmi/spmi-pmic-arb.c >>> @@ -1,4 +1,4 @@ >>> -/* Copyright (c) 2012-2013, The Linux Foundation. All rights reserved. >>> +/* Copyright (c) 2012-2015, The Linux Foundation. All rights reserved. >> >> run checkpatch, there are tons of errors like white spaces and DOS line >> ending. > > I dont see any DOS line endings with these patches. I believe the > checkpatch warnings also are false positives. > My fault, I wrongly saved the patch using Thinderbird. But the above obviously breaks multiline comments coding style rules. -- regards, Stan -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
