On 08/11/2022 02:56, Bryan O'Donoghue wrote:
When converting from .txt to .yaml we didn't include descriptions for the existing regulator supplies. - vdd - vdda - vddio Add those descriptions into the yaml now as they were prior to the conversion. Mark the supplies as required as was previously the case in the .txt implementation. Warnings about missing regulators can be resolved by updating the relevant dtsi files to point to fixed always-on regulators where appropriate.
Ugh. Are they missing or are they optional/not used on these platforms? Can you possibly list all regulator warnings?
Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Cc: Rob Clark <robdclark@xxxxxxxxx> Cc: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> Cc: Sean Paul <sean@xxxxxxxxxx> Cc: David Airlie <airlied@xxxxxxxxx> Cc: Daniel Vetter <daniel@xxxxxxxx> Cc: Rob Herring <robh+dt@xxxxxxxxxx> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> Cc: linux-arm-msm@xxxxxxxxxxxxxxx Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx Cc: freedreno@xxxxxxxxxxxxxxxxxxxxx Cc: devicetree@xxxxxxxxxxxxxxx Cc: linux-kernel@xxxxxxxxxxxxxxx Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> --- .../bindings/display/msm/dsi-controller-main.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index cf782c5f5bdb0..0f7747e55b9be 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -124,6 +124,18 @@ properties: - port@0 - port@1+ vdd-supply:+ description: + Phandle to vdd regulator device node + + vddio-supply: + description: + Phandle to vdd-io regulator device node + + vdda-supply: + description: + Phandle to vdda regulator device node + required: - compatible - reg @@ -135,6 +147,9 @@ required: - assigned-clocks - assigned-clock-parents - ports + - vdd-supply + - vddio-supply + - vdda-supplyadditionalProperties: false
-- With best wishes Dmitry
