Re: [PATCH v2 00/18] mdss-dsi-ctrl binding and dts fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 08/11/2022 02:56, Bryan O'Donoghue wrote:
V2:
https://www.spinics.net/lists/linux-arm-msm/msg116326.html

Please send the whole series to both linux-arm-msm and freedreno MLs. And to all maintainers (I think it is more useful to get the whole set rather than being puzzled what happens in the rest of the patches). This would allow you to drop the Cc lists from the patches and pass the whole list to git-send-email.


- Moves the DSI PHY changes to a different later series.
   There are enough dsi-controller-main changes to justify its own
   standalone series.

- The original phy-name binding change given discussion with Rob and
   Krzysztof became its own standalone series that has since been merged.
   https://www.mail-archive.com/dri-devel@xxxxxxxxxxxxxxxxxxxxx/msg403214.html

- Retains the drop of power-domain from yaml as a required property.
   I dug into the available dtsi. The apq8064 doesn't appear to have any
   GDSC which can be attached as a power-domain, which means the
   power-domain requirement is not universal across the various silicon
   versions.

I don't think 8x60/8960/8064 had GDSCs. At least msm-3.4 adds them only to msm8974.


- Adds Dmitry's RB to power-domain drop

- For the clock declarations I've
   * I noticed that the simple change I had worked for msm8939 but
     subsquently broke other dtsi which drove a bigger change to document
     the clocks on a per compatible basis.
   * Added compat strings in yaml.
   * Moved the allOf down later in the file to acomodate the if/then.
   * Number of clocks validated on a per compatible basis
   * The driver code which doesn't care about the number of clocks
     can still operate on the mdss-dsi-ctrl compat but the dts checks will
     validate against the compat string and yaml.

- vdd descriptions
   Took the previous text I missed from the .txt file - Krzysztof, Dmitry
   Adds vdd, vdda and vddio to the required list. This exposes warnings in
   existing dtsi but the previous .txt declared these regulators as
   required. - Krzysztof
V1:
This series fixes up a number of dtbs checks which are being flagged adding
in the msm8939 dtsi.


When converting from .txt to .yaml a number of the parameters for the older
msm8916 silicon were not transmitted into the yaml.

Adding in the msm8939 which is a near 1:1 copy of the msm8916 in terms of
dtsi triggers a rake of dtbs checks as a result.

https://www.mail-archive.com/dri-devel@xxxxxxxxxxxxxxxxxxxxx/msg403211.html

Bryan O'Donoghue (18):
   dt-bindings: msm: dsi-controller-main: Fix operating-points-v2
     constraint
   dt-bindings: msm: dsi-controller-main: Fix power-domain constraint
   dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in
   dt-bindings: msm: dsi-controller-main: Fix clock declarations
   dt-bindings: msm: dsi-controller-main: Fix description of core clock
   dt-bindings: msm: dsi-controller-main: Alphanumerically sort
     compatible enum
   dt-bindings: msm: dsi-controller-main: Add compatible strings for
     every current SoC
   dt-bindings: msm: dsi-controller-main: Document clocks on a per
     compatible basis
   ARM: dts: qcom: apq8064: add compat qcom,mdss-dsi-ctrl-apq8064
   ARM: dts: qcom: msm8974: Add compat qcom,mdss-dsi-ctrl-msm8974
   arm64: dts: qcom: msm8916: Add compat qcom,mdss-dsi-ctrl-msm8916
   arm64: dts: qcom: msm8996: Add compat qcom,mdss-dsi-ctrl-msm8996
   arm64: dts: qcom: sc7180: Add compat qcom,mdss-dsi-ctrl-sc7180
   arm64: dts: qcom: sc7280: Add compat qcom,mdss-dsi-ctrl-sc7280
   arm64: dts: qcom: sdm630: Add compat qcom,mdss-dsi-ctrl-sdm630
   arm64: dts: qcom: sdm660: Add compat qcom,mdss-dsi-ctrl-sdm660
   arm64: dts: qcom: sdm845: Add compat qcom,mdss-dsi-ctrl-sdm845
   arm64: dts: qcom: sm8250: Add compat qcom,mdss-dsi-ctrl-sm8250

  .../display/msm/dsi-controller-main.yaml      | 185 ++++++++++++++++--
  arch/arm/boot/dts/qcom-apq8064.dtsi           |   3 +-
  arch/arm/boot/dts/qcom-msm8974.dtsi           |   3 +-
  arch/arm64/boot/dts/qcom/msm8916.dtsi         |   3 +-
  arch/arm64/boot/dts/qcom/msm8996.dtsi         |   6 +-
  arch/arm64/boot/dts/qcom/sc7180.dtsi          |   3 +-
  arch/arm64/boot/dts/qcom/sc7280.dtsi          |   3 +-
  arch/arm64/boot/dts/qcom/sdm630.dtsi          |   3 +-
  arch/arm64/boot/dts/qcom/sdm660.dtsi          |   3 +-
  arch/arm64/boot/dts/qcom/sdm845.dtsi          |   6 +-
  arch/arm64/boot/dts/qcom/sm8250.dtsi          |   6 +-
  11 files changed, 194 insertions(+), 30 deletions(-)


--
With best wishes
Dmitry




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux