At 2022-11-07 17:02:29, "Greg KH" <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: >On Mon, Nov 07, 2022 at 04:48:26PM +0800, Slark Xiao wrote: >> To make code neat and for convenience purpose, use macro for >> some VIDs. These macros are supposed to be added to pci_ids.h. > >No, they are not supposed to be added there at all. > >And they are not a "macro", it is a "#define". > >> But until the macros are used in multiple places, it is not >> recommended. So adding it locally for now. > >Again, these are not macros > >thanks, > >greg k-h Hi Greg, Thanks for your comment. In my opinion, MACRO almost same as a '#define'. May I know how do you call such definition? And could you give your comments in previous patch, not the 'final' one? In another pci_ids patch, you break it in v3 and break it here again in v2. Honestly, it's positive for whole project. But it's negative for contributor and maintainer. Finally, it's welcome to point out the error.
