On Mon, Nov 07, 2022 at 04:48:26PM +0800, Slark Xiao wrote: > To make code neat and for convenience purpose, use macro for > some VIDs. These macros are supposed to be added to pci_ids.h. No, they are not supposed to be added there at all. And they are not a "macro", it is a "#define". > But until the macros are used in multiple places, it is not > recommended. So adding it locally for now. Again, these are not macros thanks, greg k-h