Hi Vikash, On Mon, Oct 24, 2022 at 11:20 PM Vikash Garodia <vgarodia@xxxxxxxxxxxxxxxx> wrote: > > Hi Dmitry, > > > -----Original Message----- > > From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > Sent: Thursday, October 20, 2022 11:31 PM > > To: Nathan Hebert <nhebert@xxxxxxxxxxxx> > > Cc: Vikash Garodia <vgarodia@xxxxxxxxxxxxxxxx>; Rob Clark > > <robdclark@xxxxxxxxx>; linux-firmware@xxxxxxxxxx; linux-arm- > > msm@xxxxxxxxxxxxxxx; Vikash Garodia (QUIC) <quic_vgarodia@xxxxxxxxxxx>; > > Fritz Koenig <frkoenig@xxxxxxxxxxxx>; Bjorn Andersson > > <andersson@xxxxxxxxxx> > > Subject: Re: [PULL]: qcom: SC7180 and SC7280 venus firmware updates > > > > WARNING: This email originated from outside of Qualcomm. Please be wary of > > any links or attachments, and do not enable macros. > > > > Hi, > > > > On Thu, 20 Oct 2022 at 19:52, Nathan Hebert <nhebert@xxxxxxxxxxxx> > > wrote: > > > > > > On Wed, Oct 19, 2022 at 10:09 AM Vikash Garodia > > > <vgarodia@xxxxxxxxxxxxxxxx> wrote: > > > > > > > > Hi Rob, > > > > > > > > > -----Original Message----- > > > > > From: Rob Clark <robdclark@xxxxxxxxx> > > > > > Sent: Wednesday, October 19, 2022 9:32 PM > > > > > To: Nathan Hebert <nhebert@xxxxxxxxxxxx> > > > > > Cc: linux-firmware@xxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; > > > > > Vikash Garodia (QUIC) <quic_vgarodia@xxxxxxxxxxx>; Fritz Koenig > > > > > <frkoenig@xxxxxxxxxxxx>; Bjorn Andersson <andersson@xxxxxxxxxx> > > > > > Subject: Re: [PULL]: qcom: SC7180 and SC7280 venus firmware > > > > > updates > > > > > > > > > > WARNING: This email originated from outside of Qualcomm. Please be > > > > > wary of any links or attachments, and do not enable macros. > > > > > > > > > > Actually, isn't the .mbn the joined fw? If so all you need to do > > > > > is remove the other files? > > > > .mbn is the complete firmware image. We have migrated to .mbn for > > > > sc7280, while the Initial days of sc7280 was with .mdt binaries > > > > (split ones). So to support the boards which Have not upgraded the driver, > > we are retaining all binaries. > > > > > > > > > > Thanks for the feedback (on and off-list). I will push a V2 of the > > > pull request with the following changes: > > > > > > 1. Update both split and non-split binaries for venus-5.4 (SC7180). > > > Also, update the version in WHENCE. We can remove the legacy split > > > images in a later commit if it is feasible to do so. > > > > The mdt loader doesn't care about the file extension, the mdt loader will > > determine the type of the file based on the file contents. Thus I'd suggest adding > > only mbn files and adding a compat symlinks pointing from venus.mdt to > > venus.mbn > > sc7180 is using venus-5.4 firmware and currently the name is passed as "qcom/venus-5.4/venus.mdt" while making call to "request_firmware()" > https://elixir.bootlin.com/linux/latest/source/drivers/media/platform/qcom/venus/core.c#L765 > https://elixir.bootlin.com/linux/latest/source/drivers/media/platform/qcom/venus/firmware.c#L104 Thanks for the code links! That is helpful. > > IIUC, before we remove the split files (.mdt), we should also make change in driver to update the name from .mdt to .mbn. > Please help to clarify if we can remove the split files with driver still referring to "qcom/venus-5.4/venus.mdt" in call to request_firmware(). I think Dmitry is saying that we could remove the venus.b0* files and replace the venus.mdt file with a symbolic link to venus.mbn. This would achieve the goal of reducing the size of the files that are stored and deployed, while staying compatible with the existing driver code. The best solution would probably be to change the driver to load the .mbn files, but using the symbolic link seems like a good intermediate solution. If there is no complaint about Dmitiry's suggestion, I will make a PR V3 with an additional commit to remove the split files and use a symbolic link linking venus.mdt to venus.mbn. This commit will precede the commit to update venus 5.4 firmware. > > > > 2. Remove the split firmware images for vpu-2.0 (SC7280). There is no > > > released device that uses the older firmware loader. I have tested to > > > make sure the non-split image can be loaded and that the venus media > > > functions work on a > > > SC7280 device using a ChromeOS kernel based on 5.15. > > > 3. Update the VPU-2.0 non-split binaries to the latest version and > > > update the version in the WHENCE file. > > > > > > -- > > With best wishes > > Dmitry
