On 24/10/2022 12:48, Dmitry Baryshkov wrote: > On 24/10/2022 19:46, Krzysztof Kozlowski wrote: >> On 24/10/2022 12:45, Dmitry Baryshkov wrote: >>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote: >>>> On 09/12/2021 05:35, Vinod Koul wrote: >>>>> Add the spmi bus as found in the SM8450 SoC >>>>> >>>>> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> >>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> >>>>> --- >>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ >>>>> 1 file changed, 18 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>> index f75de777f6ea..b80e34fd3fe1 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { >>>>> interrupt-controller; >>>>> }; >>>>> >>>>> + spmi_bus: spmi@c42d000 { >>>>> + compatible = "qcom,spmi-pmic-arb"; >>>>> + reg = <0x0 0x0c400000 0x0 0x00003000>, >>>>> + <0x0 0x0c500000 0x0 0x00400000>, >>>>> + <0x0 0x0c440000 0x0 0x00080000>, >>>>> + <0x0 0x0c4c0000 0x0 0x00010000>, >>>>> + <0x0 0x0c42d000 0x0 0x00010000>; >>>> >>>> This is a patch from December 2021. Is there anything blocking it from >>>> being merged? >>>> >>>> The same applies to several other patches here. >>> >>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb support >>> for the PMIC on the SM8450 platform. Thus we also can not merge the DT >>> parts. >> >> Why we cannot merge DTS? How is DTS with new nodes depending on any >> driver changes? > > In this particular case, there was an open question, what should be the > bindings for the PMIC ARB v7. Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait with this one. I just had an impression that it's about driver changes... > >> >> Just like I replied to Konrad - if that's true, bindings are simply >> wrong and should be fixed. > > Maybe I missed the reply. Which email are you referring to? I meant about this one: https://lore.kernel.org/linux-arm-msm/8c1428a6-f268-cb03-3e55-887d30236924@xxxxxxxxxx/T/#m50f4c72775492046f9b0a172e974cab83563af3c Best regards, Krzysztof