On 10/11/2022 12:19 PM, Krzysztof Kozlowski wrote: > On 11/10/2022 15:05, Melody Olvera wrote: >> >> On 10/11/2022 11:57 AM, Krzysztof Kozlowski wrote: >>> On 11/10/2022 14:48, Melody Olvera wrote: >>>> On 10/1/2022 2:14 AM, Krzysztof Kozlowski wrote: >>>>> On 01/10/2022 05:06, Melody Olvera wrote: >>>>>> Add tlmm node for the QDU1000 and QRU1000 SoCs and the uart pin >>>>>> configuration. >>>>> The patchset should be squashed with previous. There is no point in >>>>> bringing support piece by piece. You can bring support in steps if you >>>>> submissions are separate in time. But if you have everything ready - >>>>> your patch must be complete and bisectable. >>>> To be clear, does it make more sense to submit the base dt first, then submit each >>>> driver with all the dt changes as one patchset? >>> No, because you have DTS ready. There is no incremental work here. >> Ah ok so just squash all these commits into one and submit. > Except the board DTS. Other bigger, self-contained pieces of work can be > also kept separate, but such work is not "add a DMA". Such work could be > - add display (with clocks, DMA, GPU, power domains) or sound (again > multiple separate devices added). Understood. Yeah I figured leave the dts files as a separate commit, but do one big commit for the dtsi file, and one for the dts files. > > Best regards, > Krzysztof > Thanks, Melody
