On 20/09/2022 10:57, Bhupesh Sharma wrote:
>>> crypto: crypto@8e3a000 {
>>> - compatible = "qcom,crypto-v5.1";
>>> + compatible = "qcom,ipq4019-qce";
>>
>> There are few issues here:
>> 1. Compatible is not documented.
>
> Its documented here:
> https://lore.kernel.org/linux-arm-msm/30756e6f-952f-ccf2-b493-e515ba4f0a64@xxxxxxxxxx/
>
> [as mentioned in the dependency section in the cover letter :)]
>
>> 2. Compatible is not supported by old kernel - ABI break.
You cannot fix this with dependencies/ordering.
>> 3. Everything won't be bisectable...
>
> I think its a question of dependencies b/w the patchsets intended for
> separate areas. Let me think more on how, I can resolve it in newer
> versions.
DTS always goes separately so this also cannot be fixed with ordering or
dependencies. However if Bjorn is fine with it, it's good.
Best regards,
Krzysztof
