Re: [PATCH v2 03/30] dt-bindings: phy: qcom,qmp: drop redundant descriptions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 14, 2022 at 11:07:21AM +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 15:46, Johan Hovold wrote:
> > Drop the redundant supply and clock descriptions which did not add much
> > information beyond what can be inferred from the corresponding resource
> > names.
> > 
> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> 
> 
> (...)
> 
> >              - const: ref
> >              - const: refgen
> >          resets:
> > -          items:
> > -            - description: reset of phy block.
> > +          maxItems: 1
> >          reset-names:
> >            items:
> >              - const: phy
> > @@ -376,11 +334,7 @@ allOf:
> >      then:
> >        properties:
> >          clocks:
> > -          items:
> > -            - description: Phy aux clock.
> > -            - description: 19.2 MHz ref clk source.
> > -            - description: 19.2 MHz ref clk.
> 
> Here and in other places - I think you loose information, because the
> frequency is not mentioned in clock name.

Right, but it is also arguable redundant information for the binding
(similar for the vdda-pll voltage).

I can add a comment after the name if you prefer that?

Johan



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux