On 07/07/2022 10:15, Satya Priya wrote:
> From: Taniya Das <quic_tdas@xxxxxxxxxxx>
>
> The lpass audio supports TX/RX/WSA block resets. Disable the LPASS PIL
> clock by default, boards can enable it if needed.
You made here few different changes at once but I fail to see why. The
most important message in commit msg is "why?". Why are you disabling
LPASS PIL by default?
>
> Also to keep consistency update lpasscore to lpass_core.
This definitely should not be backported to stable.
>
> Fixes: 9499240d15f2 ("arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers")
This does not look right or I did not understand where the bug is.
Please describe what is the error/issue/bug being fixed (which would
explain the need of backporting).
More over, the patch alone brings regression - disables the LPASS PIL
while before it was enabled. For sure it should not be backported.
> Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
> Signed-off-by: Satya Priya <quic_c_skakit@xxxxxxxxxxx>
> ---
> Changes since V1:
> - Updated the phandle reference in lpass_aon node.
> - As per Matthias' comment updated the commit text.
>
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Best regards,
Krzysztof
