On Fri, Jul 08, 2022 at 12:14:45PM +0300, Dmitry Baryshkov wrote: > On 01/07/2022 02:11, Rob Herring wrote: > > On Sun, Jun 26, 2022 at 02:25:13AM +0300, Dmitry Baryshkov wrote: > > > Move properties common to all DPU DT nodes to the dpu-common.yaml > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > --- > > > .../bindings/display/msm/dpu-common.yaml | 47 +++++++++++++++++++ > > > .../bindings/display/msm/dpu-msm8998.yaml | 28 ++--------- > > > .../bindings/display/msm/dpu-qcm2290.yaml | 29 ++---------- > > > .../bindings/display/msm/dpu-sc7180.yaml | 32 ++----------- > > > .../bindings/display/msm/dpu-sc7280.yaml | 32 ++----------- > > > .../bindings/display/msm/dpu-sdm845.yaml | 32 ++----------- > > > 6 files changed, 67 insertions(+), 133 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml > > > new file mode 100644 > > > index 000000000000..f3465ee3a4ab > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml > > > @@ -0,0 +1,47 @@ > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Qualcomm Display DPU dt properties (common properties) > > > + > > > +maintainers: > > > + - Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > + - Krishna Manikandan <quic_mkrishn@xxxxxxxxxxx> > > > + - Rob Clark <robdclark@xxxxxxxxx> > > > + > > > +description: | > > > + Device tree bindings for the DPU display controller, common properties. > > > > Common properties for QCom DPU display controller > > > > > + > > > +properties: > > > + interrupts: > > > + maxItems: 1 > > > + > > > + power-domains: > > > + maxItems: 1 > > > + > > > + operating-points-v2: true > > > + > > > + ports: > > > + $ref: /schemas/graph.yaml#/properties/ports > > > > Now this schema is applied twice. > > > > > + description: | > > > + Contains the list of output ports from DPU device. These ports > > > + connect to interfaces that are external to the DPU hardware, > > > + such as DSI, DP etc. Each output port contains an endpoint that > > > + describes how it is connected to an external interface. > > > > This description is marginally useful. Each port will say it is an > > output to X. So you could just remove. > > I think I will go the other way around. It is not really useful to describe > individual ports, so I will leave just this piece, slightly rephrased and > drop individual /ports, /ports/port@N from dpu-foo.yaml. How is describing individual port not useful? You must define what each port is. Input or output. Type of data. Are they all the same? Rob
