Hi Mike, On 09/26/14 19:32, Mike Rapoport wrote: > CM-QS600 is a APQ8064 based computer on module. > The details are available at > http://compulab.co.il/products/computer-on-modules/cm-qs600/ > > Signed-off-by: Mike Rapoport <mike.rapoport@xxxxxxxxx> Thanks for working on this! Some minor notes... Can we have the subject aligned with other submissions, e.g. ARM: dts: qcom: ... ? > --- > v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested > v3 changes: add board details and keep dts Makefile sorted alphabetically [...] > new file mode 100644 > index 0000000..db7cf03 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts > @@ -0,0 +1,59 @@ [...] > + eeprom: eeprom@52 { > + compatible = "atmel,24c128"; I believe the above should be 24c02. And the address is 0x50. > + reg = <0x52>; > + pagesize = <32>; pagesize is 16. [...] Apart from the eeprom stuff above: Acked-by: Igor Grinberg <grinberg@xxxxxxxxxxxxxx> -- Regards, Igor. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
