Hi, On Wed, Jul 6, 2022 at 3:04 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 06/07/2022 11:36, Jimmy Chen wrote: > > To keep the consistency of the format for Chromebook items, > > we basically add these items based on the rules discussed in the previous patch series here > > https://lore.kernel.org/all/20220520143502.v4.1.I71e42c6174f1cec17da3024c9f73ba373263b9b6@changeid/. > > > > We are little configured with “one entry - one enum “. Do you mean something like below example? > > We suggest keep items separated as it is more readable. > > > > - description: Google Villager > > items: > > - const: google,villager-rev0 > > - const: google,villager > > - const: google,villager-rev0-sku0 > > - const: google,villager-sku0 > > - const: qcom,sc7280 > > > > Is this a reply to something we discussed? There is no quote here, but I > remember pointing out some issues with one of Google patches recently. > Unfortunately my mailbox receives like 300 mails per day, so this does > not help... Jimmy did add a link to the series where the previous discussion was in his reply, though he provided a link to patch #1 in the series and not patch #4 (where the discussion was). Relevant links: * You saying you liked the enum [1]. * Me saying I liked them separate and that switching from a "description" to a comment was opposite of what Stephen had previous voted for [2], but could change if there was overwhelming need to make them an enum. * Rob saying he prefers an enum but lets sub-arch maintainers decide [3]. * Bjorn (the sub-arch maintainer) landing the patch without the enum [4]. [1] https://lore.kernel.org/r/a2bcac04-23ad-d1ae-84f1-924c4dbad42b@xxxxxxxxxx/ [2] https://lore.kernel.org/r/CAD=FV=WgYbD9GN_wiR29ikZMzEjKUSZGH588+nnyd3O-dNgChQ@xxxxxxxxxxxxxx/ [3] https://lore.kernel.org/r/20220601232614.GA504337-robh@xxxxxxxxxx/ [4] https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=5069fe941f76c9f37abc98636a7db33a5ac72840 Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> -Doug
