On 04/07/2022 09:09, Jimmy Chen wrote: > This adds yaml file for new a LTE skus for villager device. > > Signed-off-by: Jimmy Chen <jinghung.chen3@xxxxxxxxxxx> > --- > > Documentation/devicetree/bindings/arm/qcom.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 4dd18fbf20b68..a136b1389c2ac 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -529,11 +529,26 @@ properties: > - const: google,herobrine > - const: qcom,sc7280 > > + - description: Google Villager (rev0) > + items: > + - const: google,villager-rev0 > + - const: qcom,sc7280 > + > - description: Google Villager (newest rev) > items: > - const: google,villager > - const: qcom,sc7280 > > + - description: Google Villager with LTE (rev0) > + items: > + - const: google,villager-rev0-sku0 > + - const: qcom,sc7280 > + > + - description: Google Villager with LTE (newest rev) > + items: > + - const: google,villager-sku0 > + - const: qcom,sc7280 > + All these should be one entry - one enum. If you really need some descriptive text, add a comment. Best regards, Krzysztof
