On Mon, 27 Jun 2022 14:28:02 -0700, Stephen Boyd wrote: > Trogdor devices that have a detachable keyboard still have a > non-detachable keyboard input device present because we include the > cros-ec-keyboard.dtsi snippet in the top-level sc7180-trogdor.dtsi file > that every variant board includes. We do this because the > keyboard-controller node also provides some buttons like the power > button and volume buttons. Unfortunately, this means we register a > keyboard input device that doesn't do anything on boards with a > detachable keyboard. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sc7180-trogdor: Split out keyboard node and describe detachables commit: a10b760b7402563661fa305882b181a75a1d4894 Best regards, -- Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>