Hi, On Mon, Jun 27, 2022 at 2:28 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > Trogdor devices that have a detachable keyboard still have a > non-detachable keyboard input device present because we include the > cros-ec-keyboard.dtsi snippet in the top-level sc7180-trogdor.dtsi file > that every variant board includes. We do this because the > keyboard-controller node also provides some buttons like the power > button and volume buttons. Unfortunately, this means we register a > keyboard input device that doesn't do anything on boards with a > detachable keyboard. > > Change the node's compatible on detachables to the newly introduced > "google,cros-ec-keyb-switches" compatible to indicate that there are > only switches and no keyboard to register. Similarly, move the keyboard > include that defines the keyboard-controller node out of > sc7180-trogdor.dtsi to boards that actually have a keyboard so that the > matrix properties are not defined on boards with the switches > compatible. Future boards can either use the include approach or the > node definition approach to describe a keyboard with possible switches > or just some switches. > > Cc: Benson Leung <bleung@xxxxxxxxxxxx> > Cc: Guenter Roeck <groeck@xxxxxxxxxxxx> > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Cc: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> > Cc: "Joseph S. Barrera III" <joebar@xxxxxxxxxxxx> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > --- > > Changes from v1 (https://lore.kernel.org/r/20220518172525.3319993-1-swboyd@xxxxxxxxxxxx): > * Rebased onto Joe's series applied on top of qcom's arm64-fixes-for-4.19 > * Updated more dtsi files > > arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 4 ++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi | 6 ++++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 1 + > arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland.dtsi | 6 ++++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 1 + > arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 2 ++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick.dtsi | 6 ++++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 2 ++ > arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi | 4 ++++ > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 - > 11 files changed, 33 insertions(+), 2 deletions(-) Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
