On Sep 23, 2014, at 12:55 PM, Josh Cartwright <joshc@xxxxxxxxxxxxxx> wrote: > On Tue, Sep 23, 2014 at 12:48:42PM -0500, Kumar Gala wrote: >> >> On Sep 23, 2014, at 1:28 AM, Pramod Gurav <pramod.gurav@xxxxxxxxxxxxxxx> wrote: >> >>> +linux-arm-msm >>> On Tuesday 23 September 2014 11:38 AM, Pramod Gurav wrote: >>>> This change replaces use of arm_pm_restart with recently introduced >>>> reset mechanism in Linux kernel called restart_notifier. >> >> Can you update the commit message to include details about the priority level we are setting it to. >> >> Probably something like Josh had: >> >> Choose priority 128, as according to documentation, this mechanism "is >> sufficient to restart the entire system?. >> >> Hmm, what happens if we have ps_hold restart and msm-poweroff enabled. >> Which one should have priority? > > I would hope we would avoid a situation where both this driver is > probed, and the pinctrl-msm driver has registered a restart handler? > > That is, we wouldn't ever mix the pinctrl-msm ps_hold mechanism (for > MSM8660/MSM8960/APQ8064, etc) and msm-poweroff (APQ8074 and later). Is > this a case you're worried about? Yes, I’m worried about possibly case of having both solutions on a device. - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html