On Sun, 19 Jun 2022 at 02:53, Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxx> wrote:
>
>
>
> On 17.06.2022 14:29, Dmitry Baryshkov wrote:
> > As we are converting this platform to use DT clock bindings, add clocks
> > and clock-names properties to the MMCC device tree node.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
>
>
> Sidenote: would RPM XO work here, or is it broken on 8996?
I was not sure, which of XOs should be used here, thus I just left the xo_board.
We already have several other devices on 8996 which use xo_board, so
ideally we should fix all of them later.
>
> Konrad
> > arch/arm64/boot/dts/qcom/msm8996.dtsi | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > index dffb87a5ee74..0c7b7cd9f23e 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > @@ -751,6 +751,22 @@ mmcc: clock-controller@8c0000 {
> > #reset-cells = <1>;
> > #power-domain-cells = <1>;
> > reg = <0x008c0000 0x40000>;
> > + clocks = <&xo_board>,
> > + <&gcc GCC_MMSS_NOC_CFG_AHB_CLK>,
> > + <&gcc GPLL0>,
> > + <&dsi0_phy 1>,
> > + <&dsi0_phy 0>,
> > + <0>,
> > + <0>,
> > + <0>;
> > + clock-names = "xo",
> > + "gcc_mmss_noc_cfg_ahb_clk",
> > + "gpll0",
> > + "dsi0pll",
> > + "dsi0pllbyte",
> > + "dsi1pll",
> > + "dsi1pllbyte",
> > + "hdmipll";
> > assigned-clocks = <&mmcc MMPLL9_PLL>,
> > <&mmcc MMPLL1_PLL>,
> > <&mmcc MMPLL3_PLL>,
> >
--
With best wishes
Dmitry
